Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve CLI input validation + secret checking #808

Open
wants to merge 15 commits into
base: main
Choose a base branch
from
Open

Improve CLI input validation + secret checking #808

wants to merge 15 commits into from

Conversation

bkorycki
Copy link
Contributor

  • Modelbench and modelgauge CLIs preform clean and consistent UID validation for SUT, Test, and Annotator parameters
  • Modelbench CLI nicely reports all missing secrets at the start of execution. This includes secrets for SUTs, the tests in the benchmark, and the benchmark's tests' annotators.
  • All input validation (e.g. locale, prompt_set, etc.) and secret checking for modelbench CLI happens in get_suts and get_benchmark

@bkorycki bkorycki requested a review from a team as a code owner January 21, 2025 23:22
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 21, 2025 •
edited
Loading

MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅

@bkorycki bkorycki temporarily deployed to Scheduled Testing January 21, 2025 23:31 — with GitHub Actions Inactive
@bkorycki bkorycki temporarily deployed to Scheduled Testing January 21, 2025 23:31 — with GitHub Actions Inactive
@bkorycki bkorycki temporarily deployed to Scheduled Testing January 21, 2025 23:31 — with GitHub Actions Inactive
wpietri
wpietri approved these changes Jan 21, 2025
View reviewed changes
Copy link
Contributor

@wpietri wpietri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! I'm glad you got the click validator stuff working. It's great to kick out the bad inputs early.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wpietri wpietri wpietri approved these changes

@rogthefrog rogthefrog Awaiting requested review from rogthefrog

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bkorycki @wpietri