Conversation templates for Qwen and StableLM #285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
DavidGOrtega
commented
Feb 3, 2024
•
DavidGOrtega
commented
- Adds qwen
- Adds stablels-3b
- Adds stablelm-2
- Fixes chatml not able to be extended with config json
CharlieFRuan
approved these changes
Feb 3, 2024
There was a problem hiding this comment.
LGTM thanks! One single nit looking at https://github.com/mlc-ai/mlc-llm/blob/main/cpp/conv_templates.cc#L699
CharlieFRuan
added a commit
that referenced
this pull request
Feb 15, 2024
The new version includes two main changes: 1. We now support models compiled with `PagedKVCache` (only Llama-variants for now) - This is breaking in the sense that, in order to use the update Llama WASMs, an update to the WebLLM npm is required - WASMs updated here: mlc-ai/binary-mlc-llm-libs#90 - For more see #293 2. We now support `GenerationConfig`, allowing configuring each generation (e.g. repetition penalty, temperature, etc.) - All WASMs needed to be recompiled since we included new function `ApplyPresenceAndRequencyPenalty()` in tvmjs - For more see #298 Other changes include: - #285
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.