Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Dynamic] M2 for S3: Compute Inline #173

Merged
merged 2 commits into from
Apr 9, 2023
Merged

[Dynamic] M2 for S3: Compute Inline #173

merged 2 commits into from
Apr 9, 2023

Conversation

jinhongyii
Copy link
Member

@jinhongyii
Copy link
Member Author

The documentation for the fix is on https://www.notion.so/TensorIR-Dynamic-Primitive-Hack-2751b354b7524a888df2386ca43eb316

@jinhongyii
Copy link
Member Author

Problem:

  • The check of compute_inline rejects the body using symbolic var n
  • The rewrite algorithm doesn’t work across multiple blocks (because the block_read_write_detector fails for nested blocks)

M1:

@spectrometerHBH spectrometerHBH self-assigned this Apr 8, 2023
@jinhongyii jinhongyii mentioned this pull request Apr 8, 2023
Merged
@MasterJH5574 MasterJH5574 merged commit 75d1588 into mlc-ai:dyn Apr 9, 2023
spectrometerHBH pushed a commit that referenced this pull request Apr 9, 2023
@jinhongyii
[Dynamic] M2 for S4: reverse compute inline (#176)
964c6ff 
Problem after S3's fix:
 - cannot get producer outside current scope
 - cannot handle dynamic shape in ReverseComputeInliner

Fix:
 - try to get leaf producer block outside current scope
- ignore non-index var when substituting in ReverseComputeInliner's
substituter

This PR depends on #173 and should be merged after #173 
cc: @tqchen @spectrometerHBH @junrushao @MasterJH5574
MasterJH5574 pushed a commit that referenced this pull request Apr 10, 2023
@jinhongyii @MasterJH5574
[Dynamic] M2 for S3: Compute Inline (#173)
dafee2e
MasterJH5574 pushed a commit that referenced this pull request Apr 10, 2023
@jinhongyii @MasterJH5574
[Dynamic] M2 for S4: reverse compute inline (#176)
bc78bda 
Problem after S3's fix:
 - cannot get producer outside current scope
 - cannot handle dynamic shape in ReverseComputeInliner

Fix:
 - try to get leaf producer block outside current scope
- ignore non-index var when substituting in ReverseComputeInliner's
substituter

This PR depends on #173 and should be merged after #173 
cc: @tqchen @spectrometerHBH @junrushao @MasterJH5574
MasterJH5574 pushed a commit that referenced this pull request Apr 10, 2023
@jinhongyii @MasterJH5574
[Dynamic] M2 for S3: Compute Inline (#173)
ef8502d
MasterJH5574 pushed a commit that referenced this pull request Apr 10, 2023
@jinhongyii @MasterJH5574
[Dynamic] M2 for S4: reverse compute inline (#176)
072c60f 
Problem after S3's fix:
 - cannot get producer outside current scope
 - cannot handle dynamic shape in ReverseComputeInliner

Fix:
 - try to get leaf producer block outside current scope
- ignore non-index var when substituting in ReverseComputeInliner's
substituter

This PR depends on #173 and should be merged after #173 
cc: @tqchen @spectrometerHBH @junrushao @MasterJH5574
MasterJH5574 pushed a commit that referenced this pull request Apr 13, 2023
@jinhongyii @MasterJH5574
[Dynamic] M2 for S3: Compute Inline (#173)
3d764d7
MasterJH5574 pushed a commit that referenced this pull request Apr 13, 2023
@jinhongyii @MasterJH5574
[Dynamic] M2 for S4: reverse compute inline (#176)
a34c58e 
Problem after S3's fix:
 - cannot get producer outside current scope
 - cannot handle dynamic shape in ReverseComputeInliner

Fix:
 - try to get leaf producer block outside current scope
- ignore non-index var when substituting in ReverseComputeInliner's
substituter

This PR depends on #173 and should be merged after #173 
cc: @tqchen @spectrometerHBH @junrushao @MasterJH5574
MasterJH5574 pushed a commit that referenced this pull request Apr 14, 2023
@jinhongyii @MasterJH5574
[Dynamic] M2 for S3: Compute Inline (#173)
31967e1
MasterJH5574 pushed a commit that referenced this pull request Apr 14, 2023
@jinhongyii @MasterJH5574
[Dynamic] M2 for S4: reverse compute inline (#176)
7ec715d 
Problem after S3's fix:
 - cannot get producer outside current scope
 - cannot handle dynamic shape in ReverseComputeInliner

Fix:
 - try to get leaf producer block outside current scope
- ignore non-index var when substituting in ReverseComputeInliner's
substituter

This PR depends on #173 and should be merged after #173 
cc: @tqchen @spectrometerHBH @junrushao @MasterJH5574
MasterJH5574 pushed a commit that referenced this pull request Apr 18, 2023
@jinhongyii @MasterJH5574
[Dynamic] M2 for S3: Compute Inline (#173)
e60370f
MasterJH5574 pushed a commit that referenced this pull request Apr 18, 2023
@jinhongyii @MasterJH5574
[Dynamic] M2 for S3: Compute Inline (#173)
6961bc8
MasterJH5574 pushed a commit that referenced this pull request Apr 21, 2023
@jinhongyii @MasterJH5574
[Dynamic] M2 for S3: Compute Inline (#173)
0be1d77
MasterJH5574 pushed a commit that referenced this pull request Apr 21, 2023
@jinhongyii @MasterJH5574
[Dynamic] M2 for S3: Compute Inline (#173)
e5f216e
tqchen pushed a commit that referenced this pull request Apr 23, 2023
@jinhongyii @tqchen
[Dynamic] M2 for S3: Compute Inline (#173)
200d0a5
MasterJH5574 pushed a commit that referenced this pull request May 3, 2023
@jinhongyii @MasterJH5574
[Dynamic] M2 for S3: Compute Inline (#173)
d47a527
vinx13 pushed a commit to vinx13/mlc-relax that referenced this pull request May 8, 2023
@psrivas2 @junrushao
Update tests to use set_input for rpc calls. (mlc-ai#173)
083e3b1 
Fix relax-hexagon tests to use set_input api, which is the correct way to invoke a function over RPC.
junrushao pushed a commit that referenced this pull request May 9, 2023
@jinhongyii @junrushao
[Dynamic] M2 for S3: Compute Inline (#173)
f77f047
junrushao pushed a commit that referenced this pull request May 10, 2023
@jinhongyii @junrushao
[Dynamic] M2 for S3: Compute Inline (#173)
f267ed4
MasterJH5574 pushed a commit that referenced this pull request May 15, 2023
@jinhongyii @MasterJH5574
[Dynamic] M2 for S3: Compute Inline (#173)
ac6f76b
tqchen pushed a commit that referenced this pull request May 20, 2023
@jinhongyii @tqchen
[Dynamic] M2 for S3: Compute Inline (#173)
86a24ba
tqchen pushed a commit that referenced this pull request May 20, 2023
@jinhongyii @tqchen
[Dynamic] M2 for S3: Compute Inline (#173)
f316f68
tqchen pushed a commit that referenced this pull request May 25, 2023
@jinhongyii @tqchen
[Dynamic] M2 for S3: Compute Inline (#173)
8a4e746
tqchen pushed a commit that referenced this pull request May 25, 2023
@jinhongyii @tqchen
[Dynamic] M2 for S3: Compute Inline (#173)
f46451e
tqchen pushed a commit that referenced this pull request Jun 1, 2023
@jinhongyii @tqchen
[Dynamic] M2 for S3: Compute Inline (#173)
7a9c8ab
tqchen pushed a commit that referenced this pull request Jun 14, 2023
@jinhongyii @tqchen
[Dynamic] M2 for S3: Compute Inline (#173)
c430c71
tqchen pushed a commit that referenced this pull request Jun 17, 2023
@jinhongyii @tqchen
[Dynamic] M2 for S3: Compute Inline (#173)
b22a05f
tqchen pushed a commit that referenced this pull request Jun 17, 2023
@jinhongyii @tqchen
[Dynamic] M2 for S3: Compute Inline (#173)
fd318d2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spectrometerHBH spectrometerHBH spectrometerHBH approved these changes

Assignees

@spectrometerHBH spectrometerHBH

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jinhongyii @spectrometerHBH @MasterJH5574 @wrongtest-intellif