Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vasil update #103

Merged
merged 86 commits into from
Sep 2, 2022
Merged

Vasil update #103

merged 86 commits into from
Sep 2, 2022

Conversation

szg251
Copy link
Collaborator

@szg251 szg251 commented May 23, 2022

Updating to the latest Plutus version, to get access to some of the Vasil features.

Resolves #98

The Plutus V2 upgrade is going through the following steps:

  • on-chain Vasil compliant version (without contract execution)
  • off-chain Vasil compliant version (with contract execution, but without V2 off-chain features)
  • off-chain Vasil compatible version (with all the whistles and bells) Vasil compatibility will be addressed in separate PR

Logic changes introduced by this PR:

  • balancing no longer adjusts outputs to have minimum Ada required, instead support for adjustUnbalancedTx Contract effect added
  • to handle inline datums and save future efforts BotPlutusInterface.CardanoCLI.utxosAt call was replaced by node querry effect with interpretation executing Cardano.Api query

⚠️Current plutus-apps dependency doesn't have metadata support

@szg251 szg251 changed the title Update to the latest plutus version Vasil update Jul 4, 2022
@@ -1,4 +1,4 @@
index-state: 2022-01-22T00:00:00Z
index-state: 2022-05-18T00:00:00Z
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fyi you can manage index-state with haskell-nix cabalProject, perhaps that's simpler...

@IAmPara0x
Copy link
Contributor

For Me: We have to update our whole test suite because, currently we directly submit the Tx in the contract using something like: submitTx, which is not correct as first we need to use adjustUnbalancedTx to make sure that every TxOut has minimum value, and then we have to use something like: submitUnBalancedTx to submit the new adjustedUnbalanced Tx. Previously we didn't have to do this because the balancing algorithm took care of ensuring that every TxOut must have minimum value, but now that's need to be handled manually.

cc: @mikekeke

@IAmPara0x IAmPara0x self-requested a review August 31, 2022 08:49
Copy link
Contributor

@IAmPara0x IAmPara0x left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There're few minor stuff left, related to docs and two small assertions in mock contract that needs to updated. But apart from that everything looks fine.

@mikekeke mikekeke merged commit 67db4a6 into master Sep 2, 2022
mikekeke added a commit that referenced this pull request Oct 17, 2022
 Support for addresses with staking keys [Plutip's #103].
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Introduce QueryNode effect for interactions with node Use cardano-api instead of cli calls Plutus V2
7 participants