-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added bodySegmentation.getPartsId()
#219
Conversation
Fantastic! This will go along well with #211 as well! I hope to add that soon as I will be recording a |
This looks good to me @alanvww. One stylistic nitpick: in the example, one line is missing the trailing semicolon In #139, we added two constants to MediaPipeSelfieSegmentation as well. I am thinking it's probably best to remove them with the change now. ml5-next-gen/src/BodySegmentation/index.js Line 189 in aa05f67
|
Thanks, @gohai! I’ll commit the changes soon. Regarding the constants in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great to me! I agree we can remove the selfie segmentation constants. Normally we might "deprecate" the property, but I did a search and they appear nowhere in the examples or documentation so I think it's good to remove.
Fantastic work, thank you! Merging! I may have some more thoughts or questions when I get to recording a video tutorial about this, stay tuned! |
@shiffman @ziyuan-linn
As we discussed in ml5js/ml5-website-v02-docsify#88 & #139 , this PR is to wrap the palette in a public method called
getPartsId()
within thebodySegmentation
. This method will return an object containing all the constants as key-value pairs, similar to thegetSkeleton()
method in BodyPose.As we are removing the
properties
section from the model documentation page, this public method ensures that the data remains accessible to all users and aligns with the consistency of other models.