Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lock version for yarn and node #173

Merged
merged 9 commits into from
Jul 19, 2024
Merged

Conversation

ziyuan-linn
Copy link
Member

This PR makes changes related to enforcing dev tool versions, no functional changes.

  • Set node.js version to 20.15.1 in package.json and contributing guide.
    • this is currently not enforced in any way
  • Set Yarn version to 4.3.1 in package.json and update contributing guide.
    • the correct Yarn version can be installed through corepack
  • rebuild yarn.lock for the new Yarn version.

@ziyuan-linn ziyuan-linn linked an issue Jul 17, 2024 that may be closed by this pull request
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The content here is not plain text.
Try delete it and run

echo "lts/iron" > .nvmrc

@ziyuan-linn ziyuan-linn marked this pull request as ready for review July 18, 2024 22:32
@ziyuan-linn ziyuan-linn requested a review from alanvww July 18, 2024 22:34
@shiffman
Copy link
Member

Looks great, thank you!!

@shiffman shiffman merged commit 17b6637 into main Jul 19, 2024
@ziyuan-linn ziyuan-linn deleted the lock-version-for-yarn-and-node branch September 15, 2024 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Specify version for yarn and node
3 participants