Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added C++ REST API #497

Merged
merged 115 commits into from
Oct 20, 2021
Merged

Added C++ REST API #497

merged 115 commits into from
Oct 20, 2021

Conversation

jastier
Copy link
Collaborator

@jastier jastier commented Oct 19, 2021

No description provided.

Manujinda Wathugala added 30 commits May 10, 2021 15:04
The external function should provide the derivative at each time point.
This is the dumbest model. Each root node predict close to the average
of the observation series.
1. All the programs compile.

2. All the tests pass.

However all the executions are not correct. The head node modeling
components are not properly integrated with CauseMos.
1. Need to do more:
   a. Cleaning
   b. Testing
1. Remember the sequence of log likelihoods throughout the sampling
process including burning.

2. Complete state now includes the log likelihood sequence.

3. Plotting function now plots the log likelihoods.
1. Added code to identify and retain the MAP sample even if we encounter
during the burning period.

2. If we encounter the MAP sample within the burning period it is always
put at res - 1 position of the retained samples and we reduce the number
of samples retained during the sample resolution period by 1.

3. Finally delphi remembers the index of the MAP sample withing the
retained samples.

Note: There are some (or more) repeated code in this push and previous
ones that needs to be cleaned up when there is more time.
The seasonality was not visible when Delphi was invoked through the
CauseMos interface. When a model is created, each concept’d period for
seasonality is inferred from data. However, it was not saved into the
serialized model.

When creating an experiment, an AnalysisGraph object is created by
deserializing the saved model. Since concept periods were not saved all
the concepts ended up having the default period of 1.
Added some methods to generate a random CAG and populate it with
synthetic observations.
1. Made the code more modularized

2. Removed some debug print lines
1. Removed commented code

2. Moved a block of code to make some repeated code identical in two
places. I did not refactor that into a separate method since it is only
a few lines of code and those few lines alone does not create a coherent
functionality.
This caused a chunk of repeated code. I feel that using a separate class
to handle the delphi.db is a better approach.
Manujinda Wathugala and others added 3 commits October 19, 2021 11:50
Implemented and debugged. Based on the Fourier decomposition.

As per my tests, it is working.
@adarshp adarshp merged commit 6669649 into master Oct 20, 2021
@adarshp adarshp deleted the dev_joseph_2 branch October 20, 2021 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants