Skip to content
This repository has been archived by the owner on Apr 20, 2024. It is now read-only.

Updated to vapor2 #27

Merged
merged 4 commits into from
Apr 27, 2017
Merged

Updated to vapor2 #27

merged 4 commits into from
Apr 27, 2017

Conversation

valen90
Copy link
Contributor

@valen90 valen90 commented Apr 24, 2017

No description provided.

@@ -11,13 +11,13 @@ extension Node {
}
}

extension Date: NodeConvertible {
public func makeNode(context: Context = EmptyNode) throws -> Node {
extension Date {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is supported in Vapor 2. Feel free to just remove it.

Copy link
Contributor

@BrettRToomey BrettRToomey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just remove that code I commented.

Package.swift Outdated
.Package(url: "https://github.com/bygri/vapor-forms.git", majorVersion:0)
.Package(url: "https://github.com/vapor/vapor.git", Version(2,0,0, prereleaseIdentifiers: ["beta"])),
.Package(url: "https://github.com/vapor/fluent-provider.git", Version(1,0,0, prereleaseIdentifiers: ["beta"]))//,
//.Package(url: "https://github.com/bygri/vapor-forms.git", majorVersion:0)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you be willing to remove this commented out line, please?

@BrettRToomey BrettRToomey merged commit 38bddae into ml-archive:master Apr 27, 2017
@valen90 valen90 deleted the feature/vapor-two branch April 27, 2017 10:37
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants