Add flag for supplying path to directory containing icons #55
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there,
Thanks for creating this handy utility! 🎉
I wanted to package this for Nix/NixOS and noticed that there are a couple issues that have to be resolved first.
For many use cases, it is inconvenient to require the icons directory to reside in the same directory as the
k8sviz
binary.In case you install the Go version manually and put the
k8sviz
binary in say/usr/local/bin
, you really don't want to have to copy a random directory containing icons in there as well, since this path is expected to only contain binariesTherefore I propose introducing a flag that makes it possible to supply the path to any directory containing the required icons.
You could then for example put the icons in
/usr/local/share/k8sviz/
and runk8sviz
like this:I made it possible to pass either an absolute path or one relative to the binary. It still defaults to
icons
so the default behaviour does not change.I also updated the README and in two separate commits, fixed all Markdown linting errors found with
mdl
and improved the portability of the shell scripts.Please let me know if anything is unclear