Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add flag for supplying path to directory containing icons #55

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

totoroot
Copy link

@totoroot totoroot commented Aug 28, 2023

Hi there,

Thanks for creating this handy utility! 🎉

I wanted to package this for Nix/NixOS and noticed that there are a couple issues that have to be resolved first.
For many use cases, it is inconvenient to require the icons directory to reside in the same directory as the k8sviz binary.

In case you install the Go version manually and put the k8sviz binary in say /usr/local/bin, you really don't want to have to copy a random directory containing icons in there as well, since this path is expected to only contain binaries

Therefore I propose introducing a flag that makes it possible to supply the path to any directory containing the required icons.
You could then for example put the icons in /usr/local/share/k8sviz/ and run k8sviz like this:

k8sviz -i /usr/local/share/k8sviz

I made it possible to pass either an absolute path or one relative to the binary. It still defaults to icons so the default behaviour does not change.

I also updated the README and in two separate commits, fixed all Markdown linting errors found with mdl and improved the portability of the shell scripts.

Please let me know if anything is unclear

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant