Skip to content

Commit

Permalink
fix: Don't hide setup_commands errors
Browse files Browse the repository at this point in the history
There seems to be no problem in propagating the `stderr` outwards,
and without this there is no feedback as to what went wrong
in the `setup_commands`.

PR #258: #258
  • Loading branch information
gabriel-v authored Apr 1, 2021
1 parent bd8c2bc commit 92418c4
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion src/mkdocstrings/handlers/python.py
Original file line number Diff line number Diff line change
Expand Up @@ -152,7 +152,6 @@ def __init__(self, setup_commands: Optional[List[str]] = None) -> None:
self.process = Popen( # noqa: S603,S607 (we trust the input, and we don't want to use the absolute path)
cmd,
universal_newlines=True,
stderr=PIPE,
stdout=PIPE,
stdin=PIPE,
bufsize=-1,
Expand Down

0 comments on commit 92418c4

Please sign in to comment.