Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

combined Dashboards into single tabbed one #48

Merged
merged 2 commits into from
Jan 27, 2023

Conversation

andi-blafasl
Copy link
Contributor

I combined the two dashboard yaml-files into a single tabbed one:
image
Nice Icons make it easy recognisable and compact in the view. Makes updating easier, no need to check two files. It also saves space on the sidebar. Hope you like it.

@mkaiser
Copy link
Owner

mkaiser commented Jan 26, 2023

Hi andi-blafasl,

that is awesome. I did not know that you can use tabs in a dashboard.

This opens multiple new opportunities: separate tabs for

  • quick overview
  • energy history (daily, weekly, monthly, yearly)
  • Control (like you already integrated)

One question before I merge:

What did you intend to make with the conditional battery charging card?

@Louisbertelsmann
Copy link
Collaborator

Already made a similar version of „history“ for my dashboard. If you want to, I can post it here this evening

@mkaiser
Copy link
Owner

mkaiser commented Jan 26, 2023

Already made a similar version of „history“ for my dashboard. If you want to, I can post it here this evening

yes please :)

@andi-blafasl
Copy link
Contributor Author

What did you intend to make with the conditional battery charging card?

I did not change anything from your .yaml files. Just combided them. This Conditional Card is already in your code 😉
After the last update i was also surprised by this new card because it was shown in the config but missing on the dashboard. Didn't know about this feature and was searching a few hours (minutes ;-) why it was not showing. 😁
As far as I understand, the card is only shown if the battery is charging. But the hard limit to 5kW is strange and the gauge would be also nice to see while discharging.
Maybe we can refactor the dashboards like you mentioned above and make the overview easier.

@Louisbertelsmann
Copy link
Collaborator

I have a bit of free time right now and am working on it a bit more. Had to add two more sensors for it to make sense (Monthly and yearly battery charge) I don‘t know if it‘s possible, but can you merge the newest version of my fork into main?

@mkaiser
Copy link
Owner

mkaiser commented Jan 26, 2023

What did you intend to make with the conditional battery charging card?

I did not change anything from your .yaml files. Just combided them. This Conditional Card is already in your code 😉 After the last update i was also surprised by this new card because it was shown in the config but missing on the dashboard. Didn't know about this feature and was searching a few hours (minutes ;-) why it was not showing. 😁 As far as I understand, the card is only shown if the battery is charging. But the hard limit to 5kW is strange and the gauge would be also nice to see while discharging. Maybe we can refactor the dashboards like you mentioned above and make the overview easier.

oh yeah, I remember putting that in sometime ago, but deleted it locally.... when I made a diff it popped up.... I guess I am very confusing sometimes.....

I have a bit of free time right now and am working on it a bit more. Had to add two more sensors for it to make sense (Monthly and yearly battery charge) I don‘t know if it‘s possible, but can you merge the newest version of my fork into main?

wil have a look at that, soon!

@Louisbertelsmann
Copy link
Collaborator

wil have a look at that, soon!

Take your time. Am still working on it. Until now I added the total pv generation for each month, the total export power for each month and the total pv generation for the current and the last year.

@Louisbertelsmann
Copy link
Collaborator

You can look at the new version here. I added some sensors and created tabs in the PV page.

@mkaiser mkaiser closed this Jan 27, 2023
@mkaiser mkaiser reopened this Jan 27, 2023
@mkaiser mkaiser merged commit b2c3fbb into mkaiser:main Jan 27, 2023
andi-blafasl added a commit to andi-blafasl/Sungrow-SHx-Inverter-Modbus-Home-Assistant that referenced this pull request Feb 4, 2023
* combined Dashboards into single tabbed one

* Updated to changed sensor name (battery_power[_raw])

---------

Co-authored-by: mkaiser <29856783+mkaiser@users.noreply.github.com>
@andi-blafasl andi-blafasl deleted the dashboard branch February 4, 2023 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants