Skip to content

Conversation

alexeyklyukin
Copy link
Collaborator

Disable stack traces for warn level, allow setting minimum log level and
disabling emitting source code line numbers in the log.

Additional YAML configuration parameters for the backup and command-line
for the restore to customize logging.

As a collaterial to refining log messages, set the String() output of
TableBackup to show unsanitized string representation, avoiding extra
quotes in the logs (so far this function is only used for logging).

Some minor stylistic changes around previously ignored errors in printf
in the files touched by other changes.

Disable stack traces for warn level, allow setting minimum log level and
disabling emitting source code line numbers in the log.

Additional YAML configuration parameters for the backup and command-line
for the restore to customize logging.

As a collaterial to refining log messages, set the String() output of
TableBackup to show unsanitized string representation, avoiding extra
quotes in the logs (so far this function is only used for logging).

Some minor stylistic changes around previously ignored errors in printf
in the files touched by other changes.
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found some fixes!

P.S. share your ideas, feedbacks or issues with us at https://github.com/fixmie/feedback (this message will be removed after the beta stage).

@alexeyklyukin alexeyklyukin merged commit 9cd2c73 into zap Jan 7, 2019
@alexeyklyukin alexeyklyukin deleted the fine-tune-zap branch January 7, 2019 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant