Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Broadlink RM4 pro (0x649b) #421

Merged
merged 2 commits into from
Sep 21, 2020
Merged

Conversation

felipediel
Copy link
Collaborator

And we have another friend.

@haglen
Copy link

haglen commented Sep 19, 2020

I got through adding my RM4 Pro through the new integration, but no entities/devices were created. I'm hoping this will fix the problem as I've got nothing right now. Log error below:

2020-09-20 01:32:57 ERROR (MainThread) [homeassistant.config_entries] Error setting up entry RM4 for broadlink
Traceback (most recent call last):
File "/usr/src/homeassistant/homeassistant/config_entries.py", line 228, in async_setup
result = await component.async_setup_entry(hass, self) # type: ignore
File "/usr/src/homeassistant/homeassistant/components/broadlink/init.py", line 28, in async_setup_entry
return await device.async_setup()
File "/usr/src/homeassistant/homeassistant/components/broadlink/device.py", line 97, in async_setup
update_manager = get_update_manager(self)
File "/usr/src/homeassistant/homeassistant/components/broadlink/updater.py", line 24, in get_update_manager
if device.api.model.startswith("RM mini"):
AttributeError: 'NoneType' object has no attribute 'startswith'

@felipediel
Copy link
Collaborator Author

Yes, this will fix.

@mjg59 mjg59 merged commit 2ae9b9d into mjg59:master Sep 21, 2020
@haglen
Copy link

haglen commented Sep 30, 2020

We’ve had a number of releases and this hasn’t made it in yet? I’ve lost support for half my home automation as a result.

@felipediel
Copy link
Collaborator Author

I opened the PR in the first hour. Not sure what else you want from me.

Use the remote for now, it's not the end of the world 🤣

@haglen
Copy link

haglen commented Oct 5, 2020

Its the end of the first world!

@felipediel
Copy link
Collaborator Author

It's available on Home Assistant 0.116.0b2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants