Allow using all of github's themes #101
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
generate-github-css
to include options for all theme types in a new generation scriptdata
attributes instead of a single class name to allow for easier mixing and matching. (This matches up closely with how Github themselves does it)type: module
to allow working withgenerate-github-markdown
which is an ESM module not a CommonJS module. This also required changing theextension.js
toextension.cjs
to continue working as it used toI believe the way the new settings are set up will preserve the existing behavior for anyone who had modified them before.
Resolves #89
Resolves #75
Please let me know if you have any questions!
I don't know much about actually publishing extensions so I believe all my changes should work for those who install them but please verify for me so I'm not accidentally breaking this for a bunch of users (myself included)