CSS Front-End Bundle updates to support multiple PortalWebResources #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…the same (at the end of the method there will be no associated mailing list)
…service for permission check. We could change this but we need to make sure that we do permission check.
…all the right method.
… here because we would be duplicating logic and if the permission check changes (because a security hole) nobody will remeber this code and come here to change it. The other option would be to use a fetch method in the remote services, but as the behavior is not clear (should it return null when user doesn't have permission? should it throw an exception?) I'd better leave it as it is
…front-end bundle servlet context
…since it seems to be thread safe.
…feray-portal into mjbradford89-LPS-54505-rebase
…resource type service
|
Just started reviewing :) |
Sent from
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.