Update SwerveSetpointGenerator to handle NaN Voltages #930
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds an option to generate a SwerveSetpoint with a specified battery voltage instead of depending on RobotController.getInputVoltage(). Additionally, by default checks if RobotController.getInputVoltage() is returning NaN and if it is, uses 12 as a sub in voltage.
|
This is inteded to solve: #930 |
mjansen4857
changed the title
|
Updated this to add the changes to the python version, move some things around, and add overloads for the java units library |
2 tasks
Luis-Leyva
added a commit
to Luis-Leyva/pathplanner
that referenced
this pull request
Dec 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an option to generate a SwerveSetpoint with a specified battery voltage instead of depending on RobotController.getInputVoltage().
Additionally, by default checks if RobotController.getInputVoltage() is returning NaN and if it is, uses 12.0 as a sub in voltage.