Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

redirect to browserDirectory when the url does not contains filename #367

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

redirect to browserDirectory when the url does not contains filename #367

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions modules/__tests__/browseFile-test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,18 @@ describe('A request to browse a file', () => {
server = createServer();
});

describe('when the URL does not contains filename', () => {
it('redirects to browseDirectory', done => {
request(server)
.get('/browse/react@16.8.0')
.end((err, res) => {
expect(res.statusCode).toBe(302);
expect(res.headers['location']).toBe('/browse/react@16.8.0/');
done();
});
});
});

describe('when the file exists', () => {
it('returns an HTML page', done => {
request(server)
Expand Down
5 changes: 5 additions & 0 deletions modules/actions/serveFileBrowser.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,11 @@ async function findEntry(stream, filename) {

async function serveFileBrowser(req, res) {
const stream = await getPackage(req.packageName, req.packageVersion, req.log);

if (!req.filename) {
return res.redirect(req.originalUrl + '/')
}

const entry = await findEntry(stream, req.filename);

if (!entry) {
Expand Down