Skip to content
/ linux Public
forked from torvalds/linux

Commit

Permalink
drm/nouveau/dispnv04: fix null pointer dereference in nv17_tv_get_ld_…
Browse files Browse the repository at this point in the history
…modes

commit 66edf3f upstream.

In nv17_tv_get_ld_modes(), the return value of drm_mode_duplicate() is
assigned to mode, which will lead to a possible NULL pointer dereference
on failure of drm_mode_duplicate(). Add a check to avoid npd.

Cc: stable@vger.kernel.org
Signed-off-by: Ma Ke <make24@iscas.ac.cn>
Signed-off-by: Lyude Paul <lyude@redhat.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20240625081828.2620794-1-make24@iscas.ac.cn
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  • Loading branch information
Ma Ke authored and gregkh committed Jul 5, 2024
1 parent 1668258 commit cb751e4
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions drivers/gpu/drm/nouveau/dispnv04/tvnv17.c
Original file line number Diff line number Diff line change
Expand Up @@ -209,6 +209,8 @@ static int nv17_tv_get_ld_modes(struct drm_encoder *encoder,
struct drm_display_mode *mode;

mode = drm_mode_duplicate(encoder->dev, tv_mode);
if (!mode)
continue;

mode->clock = tv_norm->tv_enc_mode.vrefresh *
mode->htotal / 1000 *
Expand Down

0 comments on commit cb751e4

Please sign in to comment.