Skip to content
/ linux Public
forked from torvalds/linux

Commit

Permalink
Revert "ALSA: usb-audio: Skip setting clock selector for single conne…
Browse files Browse the repository at this point in the history
…ctions"

This reverts commit 67794f8.

We need to explicitly set up the clock selector to workaround a problem
with the Behringer mixers. This was originally done in d2e8f64
("ALSA: usb-audio: Explicitly set up the clock selector")

The problem with MOTU M Series mentioned in commit message was fixed in
a different way by checking control capabilities of clock selectors.

Signed-off-by: Alexander Tsoy <alexander@tsoy.me>
Link: https://lore.kernel.org/r/20240128132338.819273-1-alexander@tsoy.me
Signed-off-by: Takashi Iwai <tiwai@suse.de>
  • Loading branch information
puleglot authored and tiwai committed Jan 29, 2024
1 parent f0d7897 commit c0787fc
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion sound/usb/clock.c
Original file line number Diff line number Diff line change
Expand Up @@ -344,7 +344,7 @@ static int __uac_clock_find_source(struct snd_usb_audio *chip,
if (ret > 0) {
/* Skip setting clock selector again for some devices */
if (chip->quirk_flags & QUIRK_FLAG_SKIP_CLOCK_SELECTOR ||
pins == 1 || !writeable)
!writeable)
return ret;
err = uac_clock_selector_set_val(chip, entity_id, cur);
if (err < 0)
Expand Down

0 comments on commit c0787fc

Please sign in to comment.