Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don’t search for miyagi config in git-ignored folders #38

Closed
mvsde opened this issue Sep 12, 2022 · 2 comments
Closed

Don’t search for miyagi config in git-ignored folders #38

mvsde opened this issue Sep 12, 2022 · 2 comments
Assignees
@mvsde
Labels
bug Something isn't working

Comments

@mvsde
Copy link
Member

mvsde commented Sep 12, 2022

At the moment all folders are searched for a miyagi config (except node_modules).

vscode-miyagi/src/lib/projects.ts

Line 41 in e7a3bdc

const configURIs = await vscode.workspace.findFiles(MIYAGI_CONFIG_GLOB, EXCLUDE_GLOB)

The extension should have an option to ignore folders (based on .gitignore or by manually specifying paths).
@mvsde mvsde added the enhancement New feature or request label Sep 12, 2022
@mvsde mvsde self-assigned this Sep 12, 2022
@mvsde
Copy link
Member Author

mvsde commented Oct 8, 2022

Blocked by microsoft/vscode#48674.

@mvsde
Copy link
Member Author

mvsde commented Oct 25, 2022

A “workaround” can be to manually invoke Git and check if a miyagi project is ignored:

https://git-scm.com/docs/git-check-ignore

@mvsde mvsde added bug Something isn't working and removed enhancement New feature or request labels Oct 25, 2022
@mvsde mvsde closed this as completed in a69d9cc Oct 25, 2022
mvsde added a commit that referenced this issue May 3, 2024
@mvsde
fix: Ignore miyagi projects in Git-ignored folders (Close #38)
52ce4c1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mvsde mvsde

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mvsde