Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

string utils: fix deprecation warnings with Qt6 #4302

Merged
merged 1 commit into from
Sep 18, 2021

Conversation

Be-ing
Copy link
Contributor

@Be-ing Be-ing commented Sep 18, 2021

No description provided.

Copy link
Contributor

@uklotzde uklotzde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@uklotzde uklotzde merged commit 3195bd5 into mixxxdj:main Sep 18, 2021
@Be-ing Be-ing deleted the string_conversions_qt6 branch September 18, 2021 22:34
case sizeof(uint):
return QString::fromUcs4(reinterpret_cast<const uint*>(wcs), ilen);
return QString::fromUcs4(reinterpret_cast<const char32_t*>(wcs), ilen);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would also be nice to adjust the case targets.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants