Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update MixpanelReactNative.podspec #150

Merged
merged 2 commits into from
Sep 14, 2022
Merged

Update MixpanelReactNative.podspec #150

merged 2 commits into from
Sep 14, 2022

Conversation

romainbriand
Copy link
Contributor

@romainbriand romainbriand commented Jul 3, 2022

Using dependency "React" is a mistake. It prevents iOS projects using Mixpanel to build when project Podfile is using static framework.
See: facebook/react-native#29633 (comment)

Using dependency "React" is a mistake. It prevents IOS projects using Mixpanel to build when project Podfile is using static framework.
See: facebook/react-native#29633 (comment)
@jaredmixpanel jaredmixpanel self-requested a review September 14, 2022 01:53
Copy link
Collaborator

@jaredmixpanel jaredmixpanel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @romainbriand, sorry this took so long to merge. We'll get a new release out shortly.

@jaredmixpanel jaredmixpanel merged commit b65cffe into mixpanel:master Sep 14, 2022
@romainbriand romainbriand deleted the patch-1 branch September 14, 2022 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants