Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: lint on push to prevent code style issues #454

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
+9 −2
Open

ci: lint on push to prevent code style issues #454

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
bcb5008
refactor: rename `build` job to `test`
hamirmahal Oct 23, 2024
d44cc87
ci: `lint` on `push` to prevent code style issues
hamirmahal Oct 23, 2024
ce776f1
refactor: rename `tests.yml` workflow to `npm.yml`
hamirmahal Oct 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions .github/workflows/tests.yml → .github/workflows/npm.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
name: Tests
name: npm

on:
push:
Expand All @@ -7,7 +7,14 @@ on:
branches: [master]

jobs:
build:
lint:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- run: npm ci
- run: npm run lint
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is already run as part of npm test:

mixpanel-js/package.json

Line 21 in 475b2c6

"test": "npm run lint && npm run unit-test",

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, I missed that. Do you want to remove npm run lint from the test script? I think it's a bit unexpected.

Feel free to close this pull request if there are no changes here that you like.


test:
runs-on: ubuntu-latest

strategy:
Expand Down