Follow CommonMark spec more precisely and make the code span rule eve…

…n more robust for future Turndown development. Fix #316.
mixmark-io · Nov 30, 2020 · 68a22b6 · 68a22b6
1 parent 8ba0446
commit 68a22b6
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 11 deletions.
diff --git a/src/commonmark-rules.js b/src/commonmark-rules.js
@@ -233,19 +233,15 @@ rules.code = {
   },
 
   replacement: function (content) {
-    if (!content.trim()) return ''
+    if (!content) return ''
+    content = content.replace(/\r?\n|\r/g, ' ')
 
+    var extraSpace = /^`|^ .*?[^ ].* $|`$/.test(content) ? ' ' : ''
     var delimiter = '`'
-    var leadingSpace = ''
-    var trailingSpace = ''
-    var matches = content.match(/`+/gm)
-    if (matches) {
-      if (/^`/.test(content)) leadingSpace = ' '
-      if (/`$/.test(content)) trailingSpace = ' '
-      while (matches.indexOf(delimiter) !== -1) delimiter = delimiter + '`'
-    }
+    var matches = content.match(/`+/gm) || []
+    while (matches.indexOf(delimiter) !== -1) delimiter = delimiter + '`'
 
-    return delimiter + leadingSpace + content + trailingSpace + delimiter
+    return delimiter + extraSpace + content + extraSpace + delimiter
   }
 }
 

diff --git a/test/index.html b/test/index.html
@@ -69,7 +69,7 @@
 
 <div class="case" data-name="code starting with a backtick">
   <div class="input"><code>`starting with a backtick</code></div>
-  <pre class="expected">`` `starting with a backtick``</pre>
+  <pre class="expected">`` `starting with a backtick ``</pre>
 </div>
 
 <div class="case" data-name="code containing markdown syntax">