-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Fixed Navbar on the top for Better User Experience #71
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for parthmittal ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The overall change looks great! Thanks for adding the videos as well.
Left a comment on the code.
Thanks! :)
"clsx": "^2.1.1", | ||
"framer-motion": "^7.3.5", | ||
"react": "^18.2.0", | ||
"react-dom": "^18.2.0", | ||
"react-icons": "^4.4.0", | ||
"react-lottie-player": "1.5.4", | ||
"smoothscroll-polyfill": "^0.4.4" | ||
"smoothscroll-polyfill": "^0.4.4", | ||
"tailwind-merge": "^2.5.4" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would avoid adding another two libraries for something that is just being used at one place and can be achieved otherwise as well.
So let's remove these and use the basics itself :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah i add 2 library clsx and tailwind-merge because i think we need that, for smoothscroll-polyfill when i run the npm install after i clone this repo, its update but the version same idk why.
The package i install it for handle the className style tailwind, there new folder named lib and there utils.js file
i used that in the Navbar
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I understood why you used them
But the same can be achieved without these libraries also. So lets avoid using that.
Hi @rhnas110, are you still working on this? Thanks! |
Issue
Fixed #69
Description
The Navbar will hide when User Scroll down, and if User Scroll up the Navbar will show, detail in the Preview.
Preview
Desktop View
2024-10-21.19-25-08.mp4
Mobile View
2024-10-21.19-25-43.mp4