Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Fixed Navbar on the top for Better User Experience #71

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

rhnas110
Copy link

Issue

Fixed #69

Description

The Navbar will hide when User Scroll down, and if User Scroll up the Navbar will show, detail in the Preview.

Preview

Desktop View

2024-10-21.19-25-08.mp4

Mobile View

2024-10-21.19-25-43.mp4

Copy link

netlify bot commented Oct 21, 2024

Deploy Preview for parthmittal ready!

Name Link
🔨 Latest commit ccb131b
🔍 Latest deploy log https://app.netlify.com/sites/parthmittal/deploys/67164ad0741f31000871c610
😎 Deploy Preview https://deploy-preview-71--parthmittal.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Owner

@mittal-parth mittal-parth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The overall change looks great! Thanks for adding the videos as well.

Left a comment on the code.

Thanks! :)

Comment on lines +13 to +20
"clsx": "^2.1.1",
"framer-motion": "^7.3.5",
"react": "^18.2.0",
"react-dom": "^18.2.0",
"react-icons": "^4.4.0",
"react-lottie-player": "1.5.4",
"smoothscroll-polyfill": "^0.4.4"
"smoothscroll-polyfill": "^0.4.4",
"tailwind-merge": "^2.5.4"
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would avoid adding another two libraries for something that is just being used at one place and can be achieved otherwise as well.

So let's remove these and use the basics itself :)

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah i add 2 library clsx and tailwind-merge because i think we need that, for smoothscroll-polyfill when i run the npm install after i clone this repo, its update but the version same idk why.

The package i install it for handle the className style tailwind, there new folder named lib and there utils.js file
image
i used that in the Navbar

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I understood why you used them

But the same can be achieved without these libraries also. So lets avoid using that.

@mittal-parth mittal-parth added enhancement New feature or request hacktoberfest labels Oct 22, 2024
@mittal-parth
Copy link
Owner

Hi @rhnas110, are you still working on this?

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request hacktoberfest
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Fixed Navbar on the top for Better User Experience
2 participants