chore: Enhance IRL test suites and update IRL test workflow #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Re-enabled 'Downloading and converting some YouTube videos to MP3 format' and 'Downloading using batch download' tests. - Improved logging for better clarity during test execution. - Streamlined test structure for readability and maintainability. - Adjusted timeouts and assertions to ensure consistent behavior. Note: These tests are not intended to run in cloud CI (e.g., GitHub Actions) due to YouTube's updated algorithm that restricts bot automation for downloading their videos. Bypassing these restrictions would require specific algorithms within the codebase, such as using proxies.
- Adjusted cron schedule to run daily at 06:00 and 18:00 (twice a day) instead four times a day. - Enhanced job naming for better clarity in CI logs. - Set specific FFmpeg version (7.0.2) for consistent test environment. - Updated comments to clarify the nature of the tests and the impact of YouTube's restrictions on cloud CI. - Modified the test command to focus on conversion tests only due to current limitations on downloading videos in CI environments.
mitsuki31
added
chore
- Added a new script named `coverage:no-dltest` to execute unit tests and filter IRL tests to include only conversion-related tests. - This script allows for targeted testing while maintaining accurate coverage reports.
- Modified the coverage workflow to run `npm run coverage:no-dltest` instead of the standard coverage command. - This change ensures that coverage reports focus on tests unaffected by YouTube's download restrictions in CI environments.
mitsuki31
added a commit
that referenced
this pull request
Sep 28, 2024
This change is also fixes an error during coverage upload due to missing coverage reports. The missing coverage reports was due to the `coverage:no-dltest` was not call the nyc command to retrieve the coverage information. Related changes: #56 Signed-off-by: Ryuu Mitsuki <dhefam31@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This pull request re-enables and enhances the IRL test suites for downloading YouTube videos and refines the IRL Test workflow to better accommodate the current testing environment.
Changes Made
Test Suite Enhancements
'Downloading and converting some YouTube videos to MP3 format'(old title) and'Downloading using batch download'tests.IRL Test Workflow Updates
7.0.2) to ensure consistency in the testing environment.Impact
These changes aim to enhance the functionality and reliability of the IRL tests while ensuring that the CI workflow is optimized for the environment. The focus on conversion tests will provide meaningful feedback without running afoul of YouTube's restrictions on automated downloads.