Fixes some issue on MinGW (Windows) 🪛

[mitsuki31]

What's Changed

• Changed the newline character (\n) in Makefile with echo "". (457a3f2)
• Update the message on cleanbin rule in Makefile. (1666711)
• Fixes unable to compile issue on Windows when using make. (a868ad9)
• Fixes trailing whitespaces. (37dd3b5)

Description

The messages which printed by make is always prints the \n as text instead treating it as a newline character on Windows with Git Bash and MinGW installed. On my device (Linux), it works well but if I'm using -e flag it would just prints the given flag.

@echo -e "some message"
# Output: e some message

So to make it fair, I've changed the newline with the implicit one (print a blank message with echo).

More details, see below:

jmatrix/Makefile

Lines 96 to 102 in 457a3f2

	@echo ""
	@echo ""
	@echo " * Include source files while packaging"
	@echo ""
	@echo " \`make [options] INCLUDE-SRC=true\`"
	@echo ""
	@echo "Usage:"

---

Besides that, there's some issue that the javac command unable to compile, because the given source files list (sourceFiles.lst) has Windows file separator (\).
In that case, javac treats it as flag then raise an error invalid flag: "\".
Once again, this issue only occur on Windows system.

So, I've once again changed the newline character from os.sep (based on operating system) to Unix-based separator (/). See below:

jmatrix/src/main/python/generate_list.py

Lines 22 to 26 in a868ad9

	('target_path'): ('/').join(['src', 'main', 'java']),
	('class_path'): ('/').join(['target', 'classes']) + '/',
	('out_path'): ('/').join(['target', 'generated-list']) + '/',
	('source'): ('/').join(['target', 'generated-list', 'sourceFiles.lst']),
	('output'): ('/').join(['target', 'generated-list', 'outputFiles.lst'])

And also instead using command based on operating system (that would cause an error when using Git Bash), the command to retrieve the sources and classes files now uses Unix command (which supports Git Bash) both Windows and Unix system.

jmatrix/src/main/python/generate_list.py

Lines 126 to 132 in a868ad9

	command = self.__command['unix']['source']
	if self.__verbose:
	Utils.pr_banner('GENERATING LIST')
	Utils.info_msg('Generating list...')
	err_code: int = os.system(command)

---

Also I've encountered some issue with the output message that given by command java -jar "path/to/jmatrix.jar" -V, and this only occurred when using make to build the project (on Windows with MinGW installed).
So here I've fixed it by adding strip() method after retrieving the config on config.xml (the config.xml itself is generated by Python program).

jmatrix/src/main/java/com/mitsuki/jmatrix/util/XMLParser.java

Lines 145 to 150 in 37dd3b5

	XMLConfig.programName = xml.getElementsByTagName("program_name").item(0).getTextContent().strip();
	XMLConfig.author = xml.getElementsByTagName("author").item(0).getTextContent().strip();
	XMLConfig.version = xml.getElementsByTagName("version").item(0).getTextContent().strip();
	XMLConfig.releaseType = xml.getElementsByTagName("version").item(0)
	.getAttributes().getNamedItem("type").getNodeValue().strip();
	XMLConfig.packageName = xml.getElementsByTagName("package").item(0).getTextContent().strip();

Summary

All of bugs and issues above only occurred on Windows operating system. And now it has been fixed and tested on Windows 10 with Git Bash as shell environment and MinGW installed.

Note It is recommended to use Git Bash instead Command Prompt or Powershell for shell environment if want to build the project using make (also make sure you've MinGW installed).
Or if you want a simple one, try using Maven. It supports both Command Prompt and Powershell.