show packages version with new switch: pipsi list --versions #78
Conversation
| def get_package_version(self, venv_path, package): | ||
| from subprocess import Popen, PIPE | ||
|
|
||
| args = [os.path.join(venv_path, BIN_DIR, 'pip'), 'freeze'] |
There was a problem hiding this comment.
at first glance it seems possible that this one might break on windows
There was a problem hiding this comment.
Why? It's used in the same way as in install:
args = [os.path.join(venv_path, BIN_DIR, 'pip'), 'install']
I have no easy way to test it on windows, but it should work fine.
There was a problem hiding this comment.
indeed, my mistake, sorry for buzzing on that
|
could you please try to accompany this one with a test, at first glance i like what i see, |
|
Is there some special way to test pipsi? Tests included in |
|
@RonnyPfannschmidt Is there anything about existing tests, how to run them etc? Or this tests doesn't work and I should create some from the scratch? |
|
@msztolcman atm i don't recall (i haven't touched the code/tests in a while and there is no travis setup) |
New switch for
listcommand:--versionsAdded versions to list of packages. Version is determined in time of install, and saved in
venv_path/package_info.jsonIt's cause is that i don't know good method to determine package versions - i'm using result of
pip freezecommand, and I don't think calling and parsing it everypipsi listcall is good enough.