Add the file reference on a YAML error message #443
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I had a process get killed half-way through writing a pending snapshot and it was difficult to debug what was going on, especially since in PRQL we gitignore pending snapshots. Not sure this is the best way — very open to feedback; in retrospect it seems somewhat verbose to add a simple reference in an error message.
mitsuhiko
approved these changes
Feb 19, 2024
|
Not perfect but also not worth optimizing this too much at the moment. I will try to clean this up a bit later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had a process get killed half-way through writing a pending snapshot and it was difficult to debug what was going on, especially since in PRQL we gitignore pending snapshots.
So this adds the file name to the error message
Not sure this is the best way — very open to feedback; in retrospect it seems somewhat verbose to add a simple reference in an error message.