Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Doxygen Output #30

Merged
merged 2 commits into from
Sep 11, 2020
Merged

Fix Doxygen Output #30

merged 2 commits into from
Sep 11, 2020

Conversation

alilleybrinker
Copy link

@alilleybrinker alilleybrinker commented Sep 2, 2020

Previous work got Doxygen set up and working with CMake, but the current Doxygen output is largely useless, for a couple reasons:

  • It is missing documentation for all functions, and only includes two types (the only two defined fully in our header file, rather than being exposed as opaque pointers).
  • The configuration is optimized for C++, not C.
  • The output when run with CMake is quite verbose.

This PR aims to resolve these issues.

@alilleybrinker alilleybrinker added A-docs Area: Documentation C-enhancement Category: Enhancement New feature or request labels Sep 2, 2020
@alilleybrinker alilleybrinker added this to the Pact Matching FFI v1 milestone Sep 2, 2020
@alilleybrinker alilleybrinker changed the title WIP: Fix Doxygen Output Fix Doxygen Output Sep 2, 2020
@alilleybrinker
Copy link
Author

Hey @cstepanian this is ready for review! 😄

@alilleybrinker
Copy link
Author

CC @asteffey, this will make it easier to address improvements to the documentation that we've discussed, and to make sure we can quickly provide @djorgensen-mitre with an up-to-date header file as work continues.

cstepanian
cstepanian previously approved these changes Sep 11, 2020
This commit does three things:

* Removes a `.gitkeep` file we do longer need (because the dir has a
  `.gitignore` too)
* Modifies `cbindgen.toml` to put a header at the top of the generated
  file which tells Doxygen to process it correctly.
* Modifies `CMakeLists.txt` to always rerun the header-generator, and
  further modifies Doxygen configuration as we need, plus some slight
  style improvement to the Doxygen section of the config.
@alilleybrinker alilleybrinker merged commit 9a7d67b into pact_matching_ffi Sep 11, 2020
@alilleybrinker alilleybrinker deleted the fix_doxygen_output branch September 11, 2020 14:53
alilleybrinker added a commit that referenced this pull request Sep 23, 2020
* Update Doxygen configuration in CMake

* Make Doxygen generate docs properly

This commit does three things:

* Removes a `.gitkeep` file we do longer need (because the dir has a
  `.gitignore` too)
* Modifies `cbindgen.toml` to put a header at the top of the generated
  file which tells Doxygen to process it correctly.
* Modifies `CMakeLists.txt` to always rerun the header-generator, and
  further modifies Doxygen configuration as we need, plus some slight
  style improvement to the Doxygen section of the config.
alilleybrinker added a commit that referenced this pull request Nov 4, 2020
* Update Doxygen configuration in CMake

* Make Doxygen generate docs properly

This commit does three things:

* Removes a `.gitkeep` file we do longer need (because the dir has a
  `.gitignore` too)
* Modifies `cbindgen.toml` to put a header at the top of the generated
  file which tells Doxygen to process it correctly.
* Modifies `CMakeLists.txt` to always rerun the header-generator, and
  further modifies Doxygen configuration as we need, plus some slight
  style improvement to the Doxygen section of the config.
alilleybrinker added a commit that referenced this pull request Dec 4, 2020
* Update Doxygen configuration in CMake

* Make Doxygen generate docs properly

This commit does three things:

* Removes a `.gitkeep` file we do longer need (because the dir has a
  `.gitignore` too)
* Modifies `cbindgen.toml` to put a header at the top of the generated
  file which tells Doxygen to process it correctly.
* Modifies `CMakeLists.txt` to always rerun the header-generator, and
  further modifies Doxygen configuration as we need, plus some slight
  style improvement to the Doxygen section of the config.
alilleybrinker added a commit that referenced this pull request Feb 2, 2021
* Update Doxygen configuration in CMake

* Make Doxygen generate docs properly

This commit does three things:

* Removes a `.gitkeep` file we do longer need (because the dir has a
  `.gitignore` too)
* Modifies `cbindgen.toml` to put a header at the top of the generated
  file which tells Doxygen to process it correctly.
* Modifies `CMakeLists.txt` to always rerun the header-generator, and
  further modifies Doxygen configuration as we need, plus some slight
  style improvement to the Doxygen section of the config.
alilleybrinker added a commit that referenced this pull request Apr 22, 2021
* Update Doxygen configuration in CMake

* Make Doxygen generate docs properly

This commit does three things:

* Removes a `.gitkeep` file we do longer need (because the dir has a
  `.gitignore` too)
* Modifies `cbindgen.toml` to put a header at the top of the generated
  file which tells Doxygen to process it correctly.
* Modifies `CMakeLists.txt` to always rerun the header-generator, and
  further modifies Doxygen configuration as we need, plus some slight
  style improvement to the Doxygen section of the config.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-docs Area: Documentation C-enhancement Category: Enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants