-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature - Update API for schedule (2/3) #3026
base: master
Are you sure you want to change the base?
Conversation
@sasirven we are picking this up now. Apologies for delay. |
Out of curiosity, what is the motivation behind making the obfuscator required rather than using the default value? |
840f755
to
6bf8591
Compare
As far as I remember, the default value is “plain-text,” but I’m not sure if this default value is directly available in the API. We need to add a plugin, that's right? |
@clenk @elegantmoose any additional thoughts? |
This leads me to another question: |
The operation constructor uses |
When an object schedule is created, it embeds a complete operation template in its "task" field. On the first schedule time, it creates an operation from the template. Until now, this operation was used for each subsequent schedule. This commit prevent that and creates a new operation per schedule, with the start date added in its name.
- Add a validation step to ensure the schedule field has a valid cron syntax.
6bf8591
to
8036099
Compare
This is the API part of the schedule management with cron, which depends on #3025
Linked Merge Requests:
#3025
mitre/magma#61