-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[VIRTS-2717] Operations API Tests #2219
Conversation
…eepbop/VIRTS-2002/operations-api-tests
…eepbop/VIRTS-2002/operations-api-tests
Codecov Report
@@ Coverage Diff @@
## master #2219 +/- ##
==========================================
+ Coverage 68.71% 71.04% +2.33%
==========================================
Files 94 94
Lines 7419 7419
==========================================
+ Hits 5098 5271 +173
+ Misses 2321 2148 -173
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking great! Couple other addition's that would help with completeness:
- Testing behavior for nonexistent operation IDs / link IDs
- Testing certain edge cases, like trying to update or create a finished operation.
SonarCloud Quality Gate failed. 0 Bugs No Coverage information |
…:mitre/caldera into bleepbop/VIRTS-2002/operations-api-tests
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few small changes here and there, but overall looks great!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
Description
Pytest unittests for the v2 Operations API. Note: the
DELETE
endpoint is currently untested, as there seems to be an underlying aiohttp issue with v3.6.2, causing a failure when running with tox.Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Verified that tests work for various python versions using tox.
Checklist: