Fix templated ansible_ssh_common_args issues #956
Conversation
|
@momiji you may want to add |
|
@Zocker1999NET Sure, but where? In the title, or in the text below? |
@momiji just add it to description, I don't think GitHub parses the title for that. And try to not put in a header like you already did, as GH didn't recognize that either. Probably good2know, you can use different keywords as well, see here |
moreati
changed the title
|
Correction: this does fix the |
|
I think this should be merged. I did the test on my side with mitogen 0.3.9. Without this patch, |
| C.config.get_config_value("ssh_extra_args", plugin_type="connection", plugin_name="ssh", variables=self._task_vars.get("vars", {})) | ||
| C.config.get_config_value("ssh_args", plugin_type="connection", plugin_name="ssh", variables=local_vars), | ||
| C.config.get_config_value("ssh_common_args", plugin_type="connection", plugin_name="ssh", variables=local_vars), | ||
| C.config.get_config_value("ssh_extra_args", plugin_type="connection", plugin_name="ssh", variables=local_vars) |
There was a problem hiding this comment.
Note to self:
before: variables=self._task_vars.get("vars", {})
after: variables=self._task_vars.get("hostvars", {}).get(self._inventory_name, {})
| C.config.get_config_value("ssh_extra_args", plugin_type="connection", plugin_name="ssh", variables=self._task_vars.get("vars", {})) | ||
| C.config.get_config_value("ssh_args", plugin_type="connection", plugin_name="ssh", variables=local_vars), | ||
| C.config.get_config_value("ssh_common_args", plugin_type="connection", plugin_name="ssh", variables=local_vars), | ||
| C.config.get_config_value("ssh_extra_args", plugin_type="connection", plugin_name="ssh", variables=local_vars) |
There was a problem hiding this comment.
Note to self:
before: variables=self._task_vars.get("vars", {})
after: variables=self._task_vars.get("hostvars", {}).get(self._inventory_name, {})
| C.config.get_config_value("ssh_extra_args", plugin_type="connection", plugin_name="ssh", variables=self._task_vars.get("vars", {})) | ||
| C.config.get_config_value("ssh_args", plugin_type="connection", plugin_name="ssh", variables=local_vars), | ||
| C.config.get_config_value("ssh_common_args", plugin_type="connection", plugin_name="ssh", variables=local_vars), | ||
| C.config.get_config_value("ssh_extra_args", plugin_type="connection", plugin_name="ssh", variables=local_vars) | ||
| ) | ||
| for term in ansible.utils.shlex.shlex_split(s or '') |
There was a problem hiding this comment.
Note to self:
... for term in ansible.utils.shlex.shlex_split(s or '')]probably behaves identically to
... for term in ansible.utils.shlex.shlex_split(s) if s]An experiment/test would confirm this. If true, then I think MitogenViaSpec.ssh_args() and PlayContextSpec.ssh_args() are functionally identical. I think this PR would preserve this property.
|
@momiji sorry for the exremely long wait on this PR. I'm looking at now as part of #1114. Currently this PR needs
Are you able to look at these? Otherwise I'm happy to look. May I push rebases and updates to your fork/branch momiji:master? |
Likely no to both. Momiji's fork has since been archived (Apr 18 2024). |
|
Superceded by #1115 |
Fixes #905