Add loader to podcast page #2804
Conversation
noisecapella
force-pushed
the
gs/podcasts_loader
branch
2 times, most recently
from
be4dd38 to
cf3b40e
Compare
|
I think it might be good to make the placeholder match a little more closely the content that comes to replace it - for instance the short top bar could be removed, the recent episode cards made a little shorter, and the placeholders for the podcasts cards should be portrait cards not landscape |
Codecov Report
@@ Coverage Diff @@
## master #2804 +/- ##
===========================================
+ Coverage 88.23% 98.34% +10.11%
===========================================
Files 242 511 +269
Lines 10395 19095 +8700
Branches 1172 0 -1172
===========================================
+ Hits 9172 18779 +9607
+ Misses 1055 316 -739
+ Partials 168 0 -168
Continue to review full report at Codecov.
|
noisecapella
force-pushed
the
gs/podcasts_loader
branch
from
cf3b40e to
20a78a3
Compare
|
What do you think?
|
static/js/components/Loading.js
Outdated
| </ContentLoader> | ||
| </Card> | ||
| ), | ||
| emptyPostsToRender |
There was a problem hiding this comment.
we show 6 recent episodes so it would be good I think to render 6 placeholders
static/js/components/Loading.js
Outdated
| </Card> | ||
| </Cell> | ||
| ), | ||
| emptyPostsToRender |
There was a problem hiding this comment.
we show these in a 3-item-wide grid, so it would be good to show a multiple of 3 - either 6 or 9 I think.
| describe("loader", () => { | ||
| [ | ||
| [true, true, true, true], | ||
| [true, false, true, true], |
There was a problem hiding this comment.
I think this line should be true, false, true, false, but when I change it to that locally the test stops passing
There was a problem hiding this comment.
The episode rendering looks up information in both the episode and podcasts API data, so if only the podcast data is loading, the episode list still needs to show a spinner
There was a problem hiding this comment.
ahhh that makes sense
noisecapella
force-pushed
the
gs/podcasts_loader
branch
from
20a78a3 to
97a3bc9
Compare
Pre-Flight checklist
What are the relevant tickets?
Fixes #2781
What's this PR do?
Adds a loader for the podcasts API, reusing the placeholder images we use for a loader on the search page
How should this be manually tested?
Go to
/podcasts/and verify that you see the loader briefly before the results come up.Screenshots