Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: created config file with appropriate demarcation #2

Merged
merged 5 commits into from
Aug 4, 2024

Conversation

Hari-Keshav-Rajesh
Copy link
Member

No description provided.

@Hari-Keshav-Rajesh Hari-Keshav-Rajesh linked an issue Aug 3, 2024 that may be closed by this pull request
config/home.ts Outdated
@@ -0,0 +1,27 @@
export const homeData = {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if we're going to stick to siteConfig and cardsConfig then might as well have this as homeConfig.

Suggested change
export const homeData = {
export const homeConfig = {

tagline: 'One Ecosystem for all Clubs.',
description:
'Empower your MIT Bengaluru club experience with our centralized platform, seamlessly managing and collaborating on events, blogs, and administration.',
FAQConfig : [
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should also consider making a type for FAQConfig (maybe FAQItem) so that this array can satisfy FAQItem[].

Copy link
Member

@abhigyantrips abhigyantrips left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@abhigyantrips abhigyantrips merged commit 581b054 into main Aug 4, 2024
@abhigyantrips abhigyantrips deleted the 1-config-setup branch August 4, 2024 05:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Config Setup
2 participants