Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass -native-compiler ondemand for bedrock2 ex #283

Merged
merged 1 commit into from
Oct 6, 2022

Conversation

JasonGross
Copy link
Contributor

Fixes #282

@andres-erbsen
Copy link
Contributor

This change is fine by me but I do not understand why it's necessary for their CI and not ours, and thus whether our repo is actually the right place to fix it.

@JasonGross
Copy link
Contributor Author

The Coq packages we use on CI are configured in such a way that coqnative is not run by default on builds. Note that we do this already in Fiat Crypto, I believe, which has similar problems in some places. Plausibly there's some large enough amount of stack and RAM that would allow coqnative to work here, but I don't think it's worth it, and I don't expect many people to suffer for not having the definitions from bedrock2 examples precompiled to native code

@andres-erbsen
Copy link
Contributor

But do Coq developers think that the supported usage of Coq is to automatically native-compile everything that ends in Defined?

@JasonGross
Copy link
Contributor Author

Depending on how you configure Coq, yes

@andres-erbsen
Copy link
Contributor

🤦

@andres-erbsen andres-erbsen merged commit b82ce36 into master Oct 6, 2022
@JasonGross JasonGross deleted the native-compiler-on-demand branch October 6, 2022 18:14
@SkySkimmer
Copy link
Contributor

Also depends on which developper you ask and how you phrase the question

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bedrock2 lightbulb example is incompatible with native_compute
3 participants