Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI-only: Pin importlib-resources<6.2 #661

Merged
merged 3 commits into from
Mar 17, 2024
Merged

CI-only: Pin importlib-resources<6.2 #661

merged 3 commits into from
Mar 17, 2024

Conversation

rsokl
Copy link
Contributor

@rsokl rsokl commented Mar 17, 2024

python/importlib_resources#298 is causing issues in Hydra for Python 3.8. It is most appropriate for Hydra to handle the pinning here as it is the one introducing the dependency. So we are just doing a CI-level pin so that we can keep testing vs Python 3.8.

@rsokl rsokl added test suite Changes to hydra-zen's test suite 3rd party issue Involves 3rd party depenency, maybe not a hydra-zen issue labels Mar 17, 2024
@rsokl rsokl merged commit fa57d0e into main Mar 17, 2024
18 checks passed
@rsokl rsokl deleted the avoid-importlib-issue branch March 17, 2024 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3rd party issue Involves 3rd party depenency, maybe not a hydra-zen issue test suite Changes to hydra-zen's test suite
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant