Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code style improvements and lint fixes. #43

Merged
merged 9 commits into from
Jan 15, 2024

Conversation

a-moreira
Copy link
Contributor

@a-moreira a-moreira commented Dec 21, 2023

This PR is mainly a code style suggestion, with some other small fixes.

  • Proposes a .rustfmt.toml with standardized default formatting based on the one we selected for Floresta, which is small subset of the formatting settings used by rust-bitcoin projects.
  • Some small fixes to make Clippy happy :-)
  • Remove lock file, since this project is a library, and not a binary, as suggested by this Stack Overflow question and the Cargo FAQ.

@a-moreira a-moreira changed the title Code style improvements Code style improvements and lint fixes. Dec 21, 2023
@a-moreira a-moreira force-pushed the style/code-style-improvements branch from 87c0698 to 6e7c4e9 Compare January 2, 2024 18:41
@a-moreira
Copy link
Contributor Author

just fixed some small details, it's good to go @kcalvinalvin @Davidson-Souza

@Davidson-Souza
Copy link
Collaborator

ACK 3e76bb5

@Davidson-Souza Davidson-Souza merged commit fdabb1e into mit-dci:main Jan 15, 2024
20 checks passed
Davidson-Souza added a commit to Davidson-Souza/rustreexo that referenced this pull request Jun 8, 2024
We had some bugs that would only appear on testnet.
This commit fixes them
Davidson-Souza added a commit to Davidson-Souza/rustreexo that referenced this pull request Jun 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants