Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix iOS issue with 0, 1 being interpreted as JSON bools #3285

Merged

Conversation

ewpatton
Copy link
Member

Change-Id: I6131fad2c7096d462b39dfb2214edaf36db949a0

If your code changes how something works on the device (i.e., it affects the companion):

  • I branched from ucr
  • My pull request has ucr as the base

What does this PR accomplish?

Fixes #3284 by handling edge cases where ObjC can sometimes treat 0==false and 1==true.

Test app: iOSJsonTest.aia.zip

Change-Id: I6131fad2c7096d462b39dfb2214edaf36db949a0
@ewpatton ewpatton requested a review from a team December 10, 2024 01:39
@ewpatton ewpatton linked an issue Dec 10, 2024 that may be closed by this pull request
8 tasks
@ewpatton ewpatton added the testflight This PR is deployed via Apple TestFlight label Dec 11, 2024
Copy link
Contributor

@SusanRatiLane SusanRatiLane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SusanRatiLane SusanRatiLane merged commit d771369 into mit-cml:ucr Dec 11, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

iOS issues with true/false and 1/0 encoding in JSON
2 participants