Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Redis cache plugin #50

Merged
merged 20 commits into from
Jun 29, 2024
Merged

Add Redis cache plugin #50

merged 20 commits into from
Jun 29, 2024

Conversation

mistval
Copy link
Owner

@mistval mistval commented Jun 29, 2024

  • Add Redis cache as a separate module in a plugins directory
  • Get rid of XO linter (first time trying it, finding it a huge PITA, will probably just use prettier)

campbellmc and others added 4 commits June 24, 2024 17:39
* feat: add redis cache

* fix: add shx for cross-env cp command in npm commands

* chore: remove tests for optional dependency ioredis

* fix: fix redis cache get and set methods

* fix: fix the ts type errors for redis

* fix: fix types for redis

* tests: add tests for redis cache

* chore: add requirements.txt for uv

* chore: add types/node package

* refactor: improve options handling for RedisCache class

* docs: add example for RedisCache usage

* tests: add redis cache tests using sinon and chai in separate test file.

* chore: change ioredis to optional dependency

* chore: handle missing ioredis in get/set methods

* feat: add redis cache

* fix: add shx for cross-env cp command in npm commands

* chore: remove tests for optional dependency ioredis

* fix: fix redis cache get and set methods

* fix: fix the ts type errors for redis

* fix: fix types for redis

* tests: add tests for redis cache

* chore: add requirements.txt for uv

* refactor: improve options handling for RedisCache class

* docs: add example for RedisCache usage

* tests: add redis cache tests using sinon and chai in separate test file.

* chore: change ioredis to optional dependency

* chore: handle missing ioredis in get/set methods

* docs: minor corrections to README.md

* update to non-optional ioredis

---------

Co-authored-by: Dilraj Sachdev <dilrajsachdev@gmail.com>
…e run on the other caches, fix a few issues that turned up
@codecov-commenter
Copy link

codecov-commenter commented Jun 29, 2024

Codecov Report

Attention: Patch coverage is 91.08911% with 9 lines in your changes missing coverage. Please review.

Project coverage is 98.25%. Comparing base (e324e05) to head (b52b496).

Files Patch % Lines
plugins/redis/redis_cache.ts 91.08% 9 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #50      +/-   ##
==========================================
- Coverage   99.37%   98.25%   -1.13%     
==========================================
  Files          11       12       +1     
  Lines         643      744     +101     
  Branches       68       80      +12     
==========================================
+ Hits          639      731      +92     
- Misses          4       13       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mistval mistval changed the title Add Redis cache Add Redis cache plugin Jun 29, 2024
@mistval mistval merged commit de42561 into master Jun 29, 2024
12 of 14 checks passed
@mistval mistval deleted the redis branch July 1, 2024 01:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants