-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Redis cache plugin #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* feat: add redis cache * fix: add shx for cross-env cp command in npm commands * chore: remove tests for optional dependency ioredis * fix: fix redis cache get and set methods * fix: fix the ts type errors for redis * fix: fix types for redis * tests: add tests for redis cache * chore: add requirements.txt for uv * chore: add types/node package * refactor: improve options handling for RedisCache class * docs: add example for RedisCache usage * tests: add redis cache tests using sinon and chai in separate test file. * chore: change ioredis to optional dependency * chore: handle missing ioredis in get/set methods * feat: add redis cache * fix: add shx for cross-env cp command in npm commands * chore: remove tests for optional dependency ioredis * fix: fix redis cache get and set methods * fix: fix the ts type errors for redis * fix: fix types for redis * tests: add tests for redis cache * chore: add requirements.txt for uv * refactor: improve options handling for RedisCache class * docs: add example for RedisCache usage * tests: add redis cache tests using sinon and chai in separate test file. * chore: change ioredis to optional dependency * chore: handle missing ioredis in get/set methods * docs: minor corrections to README.md * update to non-optional ioredis --------- Co-authored-by: Dilraj Sachdev <dilrajsachdev@gmail.com>
…e run on the other caches, fix a few issues that turned up
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #50 +/- ##
==========================================
- Coverage 99.37% 98.25% -1.13%
==========================================
Files 11 12 +1
Lines 643 744 +101
Branches 68 80 +12
==========================================
+ Hits 639 731 +92
- Misses 4 13 +9 ☔ View full report in Codecov by Sentry. |
This reverts commit f5eaa5e.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
plugins
directory