Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: アンテナでセンシティブなチャンネルからのノートを除外できるように #15346

Open
wants to merge 21 commits into
base: develop
Choose a base branch
from

Conversation

sevenc-nanashi
Copy link
Contributor

@sevenc-nanashi sevenc-nanashi commented Jan 25, 2025

What

タイトル通りです。

Why

closes: #14177

Additional info (optional)

手元の環境ではなぜかESLintのフォーマットが効かなかったので手動フォーマットしています。(おそらく何か間違えている...)

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@github-actions github-actions bot added packages/frontend Client side specific issue/PR packages/backend Server side specific issue/PR packages/misskey-js packages/backend:test labels Jan 25, 2025
Copy link

codecov bot commented Jan 25, 2025

Codecov Report

Attention: Patch coverage is 57.14286% with 12 lines in your changes missing coverage. Please review.

Project coverage is 44.12%. Comparing base (7c87dec) to head (a6f1d44).

Files with missing lines Patch % Lines
...ckages/frontend/src/components/MkAntennaEditor.vue 0.00% 4 Missing ⚠️
...backend/src/server/api/endpoints/antennas/notes.ts 0.00% 3 Missing ⚠️
packages/backend/src/core/AntennaService.ts 0.00% 2 Missing ⚠️
.../backend/src/core/entities/AntennaEntityService.ts 0.00% 1 Missing ⚠️
...ackend/src/server/api/endpoints/antennas/create.ts 50.00% 1 Missing ⚠️
...ackend/src/server/api/endpoints/antennas/update.ts 50.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #15346      +/-   ##
===========================================
+ Coverage    40.86%   44.12%   +3.26%     
===========================================
  Files         1609     1613       +4     
  Lines       161806   167658    +5852     
  Branches      3786     4155     +369     
===========================================
+ Hits         66119    73980    +7861     
+ Misses       95239    93198    -2041     
- Partials       448      480      +32     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented Jan 25, 2025

このPRによるapi.jsonの差分

差分はこちら
--- base
+++ head
@@ -18399,6 +18399,9 @@
                   },
                   "withFile": {
                     "type": "boolean"
+                  },
+                  "hideNotesInSensitiveChannel": {
+                    "type": "boolean"
                   }
                 },
                 "required": [
@@ -19300,6 +19303,9 @@
                   },
                   "withFile": {
                     "type": "boolean"
+                  },
+                  "hideNotesInSensitiveChannel": {
+                    "type": "boolean"
                   }
                 },
                 "required": [
@@ -81734,6 +81740,10 @@
           "notify": {
             "type": "boolean",
             "default": false
+          },
+          "hideNotesInSensitiveChannel": {
+            "type": "boolean",
+            "default": false
           }
         },
         "required": [
@@ -81752,7 +81762,8 @@
           "withFile",
           "isActive",
           "hasUnreadNote",
-          "notify"
+          "notify",
+          "hideNotesInSensitiveChannel"
         ]
       },
       "Clip": {

Get diff files from Workflow Page

@@ -626,6 +629,42 @@ describe('アンテナ', () => {
assert.deepStrictEqual(response, expected);
});

test('が取得できること(センシティブチャンネルのノートを除く)', async () => {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

これだけチャンネル作成が必要になってくるので上のeachとは別に書いています。

@sevenc-nanashi sevenc-nanashi force-pushed the feat/hide-sensitive-from-antenna branch from d8c380a to f98076e Compare January 26, 2025 10:08
@sevenc-nanashi
Copy link
Contributor Author

sevenc-nanashi commented Feb 20, 2025

そういえば:このPRってどういう状況なんでしょうか?(次のMisskey Office Hour待ちみたいな感じとか?)

@samunohito
Copy link
Member

明日レビューします!

Copy link
Member

@samunohito samunohito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

一通り見ましたが、明日の朝にもう一回見たいので見ます

Copy link
Member

@samunohito samunohito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/backend:test packages/backend Server side specific issue/PR packages/frontend Client side specific issue/PR packages/misskey-js
Projects
Status: Approved
Development

Successfully merging this pull request may close these issues.

センシティブチャンネルをアンテナから除外できる設定をつけてほしい
5 participants