update deps #15311
Merged
update deps #15311
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
packages/frontend
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #15311 +/- ##
============================================
+ Coverage 18.84% 40.34% +21.49%
============================================
Files 768 1611 +843
Lines 111607 210727 +99120
Branches 1236 4052 +2816
============================================
+ Hits 21037 85009 +63972
- Misses 89979 125108 +35129
- Partials 591 610 +19 ☔ View full report in Codecov by Sentry. |
|
misskey-dev-eslint-pluginの新バージョンのリリースが必要（必要な更新はリポジトリ自体には入っているのでリリースするだけでOK） |
した |
v7でOpenAPIのバリデーションが入るようになった関係でスコープ外での変更が避けられないため一時的に戻した
|
このPRによるapi.jsonの差分 |
|
|
nsfwjs は #15248 で言及し忘れたけど infinitered/nsfwjs#910 を踏んだので意図的に落としてた。どっかにバージョンを latest にしない理由をまとめる仕組みあったほうがいいかもな... |
v13 contains breaking changes that require some decision making
anatawa12
approved these changes
Jan 24, 2025
Comment on lines
+103
to
+104
| // See https://github.com/misskey-dev/misskey/pull/15311 | ||
| 'js/i18n.ts', |
There was a problem hiding this comment.
Upstreamに報告して / 見つけてそっちへのリンクを張りたいとおもったけど eslint の更新してないのが原因だと考えられるから一旦これでも良さそう。
eslint v9 / typescript-eslint v8のissueもないから切ったほうが良さそうですね。
Co-authored-by: anatawa12 <anatawa12@icloud.com>
下記理由から、 2025.1.0 ではなく次以降のバージョンに取り込むのが良いと考えますが、どうでしょうか
|
|
dependencyにも結構重要な脆弱性修正が入っている（Criticalあり）のでやったほうがいい気もするんですよね |
|
それなら、該当パッケージをリストアップして最低限にとどめた方がリスクが低いように思えますが… |
kakkokari-gtyih
modified the milestones:
v2025.1.0,
[DO NOT MERGE THESE YET] v2025.2.0～,
[DO NOT MERGE THESE YET] v2025.3.0～,
v2025.2.0
5 tasks
|
このバージョンのnodemonに不具合あるかも(プロセスが終了しない) |
#15284 (comment) ってこのブランチで試してたの？ |
|
ブランチ切り替えた時にpnpm iし忘れていた可能性がある(ほかのブランチでpnpm iしたら再現しなくなった) |
いま試したけどちゃんと止まったわね（WSL） |
|
二回連続でpnpm devすると発生することが判った(nodemonのバージョンは無関係だった) |
|
じゃあ一旦これはマージできる状態？ |
|
かも |
Ruruke
pushed a commit
to Ruruke/rukey
that referenced
this pull request
Feb 17, 2025
* wip * bump misskey-dev/eslint-plugin * lint fixes (backend) * lint fixes (frontend) * lint fixes (frontend-embed) * rollback nsfwjs to 4.2.0 ref: infinitered/nsfwjs#904 * rollback openapi-typescript to v6 v7でOpenAPIのバリデーションが入るようになった関係でスコープ外での変更が避けられないため一時的に戻した * lint fixes (misskey-js) * temporarily disable errored lint rule (frontend-shared) * fix lint * temporarily ignore errored file for lint (frontend-shared) * rollback simplewebauthn/server to 12.0.0 v13 contains breaking changes that require some decision making * lint fixes (frontend-shared) * build misskey-js with types * fix(backend): migrate simplewebauthn/server to v12 * fix(misskey-js/autogen): ignore indent rules to generate consistent output * attempt to fix test changes due to capricorn86/happy-dom#1617 (XMLSerializer now produces valid XML) * attempt to fix test changes due to capricorn86/happy-dom#1617 (XMLSerializer now produces valid XML) * fix test * fix test * fix test * Apply suggestions from code review Co-authored-by: anatawa12 <anatawa12@icloud.com> * bump summaly to v5.2.0 * update tabler-icons to v3.30.0-based --------- Co-authored-by: かっこかり <67428053+kakkokari-gtyih@users.noreply.github.com> Co-authored-by: anatawa12 <anatawa12@icloud.com>
Ruruke
pushed a commit
to Ruruke/rukey
that referenced
this pull request
Feb 17, 2025
* wip * bump misskey-dev/eslint-plugin * lint fixes (backend) * lint fixes (frontend) * lint fixes (frontend-embed) * rollback nsfwjs to 4.2.0 ref: infinitered/nsfwjs#904 * rollback openapi-typescript to v6 v7でOpenAPIのバリデーションが入るようになった関係でスコープ外での変更が避けられないため一時的に戻した * lint fixes (misskey-js) * temporarily disable errored lint rule (frontend-shared) * fix lint * temporarily ignore errored file for lint (frontend-shared) * rollback simplewebauthn/server to 12.0.0 v13 contains breaking changes that require some decision making * lint fixes (frontend-shared) * build misskey-js with types * fix(backend): migrate simplewebauthn/server to v12 * fix(misskey-js/autogen): ignore indent rules to generate consistent output * attempt to fix test changes due to capricorn86/happy-dom#1617 (XMLSerializer now produces valid XML) * attempt to fix test changes due to capricorn86/happy-dom#1617 (XMLSerializer now produces valid XML) * fix test * fix test * fix test * Apply suggestions from code review Co-authored-by: anatawa12 <anatawa12@icloud.com> * bump summaly to v5.2.0 * update tabler-icons to v3.30.0-based --------- Co-authored-by: かっこかり <67428053+kakkokari-gtyih@users.noreply.github.com> Co-authored-by: anatawa12 <anatawa12@icloud.com>
harumaki2000
pushed a commit
to harumaki2000/misskey-layp
that referenced
this pull request
Feb 21, 2025
* wip * bump misskey-dev/eslint-plugin * lint fixes (backend) * lint fixes (frontend) * lint fixes (frontend-embed) * rollback nsfwjs to 4.2.0 ref: infinitered/nsfwjs#904 * rollback openapi-typescript to v6 v7でOpenAPIのバリデーションが入るようになった関係でスコープ外での変更が避けられないため一時的に戻した * lint fixes (misskey-js) * temporarily disable errored lint rule (frontend-shared) * fix lint * temporarily ignore errored file for lint (frontend-shared) * rollback simplewebauthn/server to 12.0.0 v13 contains breaking changes that require some decision making * lint fixes (frontend-shared) * build misskey-js with types * fix(backend): migrate simplewebauthn/server to v12 * fix(misskey-js/autogen): ignore indent rules to generate consistent output * attempt to fix test changes due to capricorn86/happy-dom#1617 (XMLSerializer now produces valid XML) * attempt to fix test changes due to capricorn86/happy-dom#1617 (XMLSerializer now produces valid XML) * fix test * fix test * fix test * Apply suggestions from code review Co-authored-by: anatawa12 <anatawa12@icloud.com> * bump summaly to v5.2.0 * update tabler-icons to v3.30.0-based --------- Co-authored-by: かっこかり <67428053+kakkokari-gtyih@users.noreply.github.com> Co-authored-by: anatawa12 <anatawa12@icloud.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Why
Additional info (optional)
Checklist