Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typescript migration #600

Closed
wants to merge 2 commits into from
Closed

Typescript migration #600

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c75999c
Remove nested workspaces
zhouzi May 17, 2022
2c2c515
Minimal setup
zhouzi May 17, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 10 additions & 8 deletions packages/emoji-mart/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,12 +9,10 @@
"url": "https://github.com/missive/emoji-mart",
"directory": "packages/emoji-mart"
},
"workspaces": [
"packages/*"
],
zhouzi marked this conversation as resolved.
Show resolved Hide resolved
"type": "module",
"source": "src/index.js",
"source": "src/index.ts",
"main": "dist/index.js",
"types": "dist/index.d.ts",
"targets": {
"main": {
"includeNodeModules": true
Expand All @@ -32,11 +30,15 @@
"prepublishOnly": "yarn build"
},
"devDependencies": {
"@parcel/transformer-inline-string": "2.3.2",
"@parcel/transformer-sass": "2.3.2",
"@parcel/packager-ts": "2.5.0",
"@parcel/transformer-inline-string": "2.5.0",
"@parcel/transformer-sass": "2.5.0",
"@parcel/transformer-typescript-types": "2.5.0",
"autoprefixer": "10.4.4",
"parcel": "2.3.2",
"preact": "10.6.4"
"parcel": "2.5.0",
"postcss": "8.4.13",
"preact": "10.6.4",
"typescript": "4.6.4"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As suggested in #576 (comment) we need to declare the dependencies explicitly due to the --no-autoinstall flag in the build script.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be clear: even with autoinstall, dependencies would still be added to package.json, but automatically by parcel. IIRC it’s not quite compatible with workspaces and when starting from scratch you get overwhelmed with a ton of dependencies you’re not sure you even need, so I prefer to handle them manually.

I don’t think postcss requires to be explicitly added, was it? I believe it’s already included (see yarn.lock) through parcel sub-dependencies.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The dependencies I added so far were required, otherwise it was throwing a "{module} not found" error. I don't know why it is throwing for postcss though. I will try to remove it and/or figure out why it is required.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No worries. I’m still experimenting / figuring out the whole workspaces and the best way to configure everything. Are you running scripts from the root or from packages/emoji-mart? If the latter, that might be why (and also maybe why you got around the typescript issue from #576). With workspaces, you need to handle dependencies from the root. Dependencies can still be added to a specific workspace (like it currently is), but there’s only one node_modules at the root. Workspaces install all workspaces dependencies at the root.

We could even move all devDependencies to the root package.json if that helps with issues.

},
"alias": {
"react": "preact/compat",
Expand Down
0 packages/emoji-mart/src/index.js → packages/emoji-mart/src/index.ts
View file
Open in desktop
File renamed without changes.
Loading