-
Notifications
You must be signed in to change notification settings - Fork 842
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow picker to display emoji natively #40
Allow picker to display emoji natively #40
Conversation
Just a note: Haven’t forgotten about that PR, I would really love to have that in EmojiMart. Last time I tried, there was some layout issues (namely when hovering the emojis) when using native emojis in the picker. That being said, I haven’t gotten around to checking with your changes. Will try to do that very soon! |
@EtienneLem - no worries. Downloading the image sprite sheet was too slow for our product, so I think this will be a good addition. There was a css change that I probably should have submitted to make the layout better. Chrome doesn't kern emojis correctly, so in our css we had to add this to make the circle'd highlights better. .emoji-mart .emoji-mart-emoji { |
@EtienneLem Had a chance to look at this yet? Just pinging this PR again. We'd love to have this merged upstream. |
@EtienneLem Just noticed this one had a merge conflict from the previous PRs. I can resolve the conflict in the next hour or so and then you can decide to merge or not. |
No worries, I can resolve it. Got to check the CSS too. You could however either give me access to the PR or I can merge manually w/ my changes. |
…spritesheet Signed-off-by: Eric Dattore <edattore@pivotal.io>
Signed-off-by: Chad Wagner <cwagner@pivotal.io>
It looks like the "allow edits from maintainers" box is checked on the original PR, so you should have access to modify it. |
Looks great on my end, thanks so much! 🤘 |
Allow picker to display emojis native rather than just through the sprite sheet.