Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow picker to display emoji natively #40

Merged
merged 8 commits into from
Feb 17, 2017
Merged

Allow picker to display emoji natively #40

merged 8 commits into from
Feb 17, 2017

Conversation

tracker-common
Copy link

Allow picker to display emojis native rather than just through the sprite sheet.

@EtienneLem
Copy link
Member

Just a note: Haven’t forgotten about that PR, I would really love to have that in EmojiMart. Last time I tried, there was some layout issues (namely when hovering the emojis) when using native emojis in the picker.

That being said, I haven’t gotten around to checking with your changes. Will try to do that very soon!

@tracker-common
Copy link
Author

@EtienneLem - no worries. Downloading the image sprite sheet was too slow for our product, so I think this will be a good addition. There was a css change that I probably should have submitted to make the layout better. Chrome doesn't kern emojis correctly, so in our css we had to add this to make the circle'd highlights better.

.emoji-mart .emoji-mart-emoji {
padding: 6px;
cursor: pointer;
width: 32px;
}

@ELD
Copy link

ELD commented Feb 15, 2017

@EtienneLem Had a chance to look at this yet? Just pinging this PR again. We'd love to have this merged upstream.

@ELD
Copy link

ELD commented Feb 17, 2017

@EtienneLem Just noticed this one had a merge conflict from the previous PRs. I can resolve the conflict in the next hour or so and then you can decide to merge or not.

@EtienneLem
Copy link
Member

No worries, I can resolve it. Got to check the CSS too. You could however either give me access to the PR or I can merge manually w/ my changes.

@ELD
Copy link

ELD commented Feb 17, 2017

It looks like the "allow edits from maintainers" box is checked on the original PR, so you should have access to modify it.

@EtienneLem EtienneLem merged commit da5cdcf into missive:master Feb 17, 2017
@EtienneLem
Copy link
Member

Looks great on my end, thanks so much! 🤘

@tracker-common tracker-common deleted the native-emoji-picker-option branch February 17, 2017 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants