test: replace karma with jest #302
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nolanlawson
commented
Mar 14, 2019
| "start": "npm run watch", | ||
| "stats": "webpack --config ./spec/webpack.config.js --json > spec/stats.json", |
There was a problem hiding this comment.
I could not find a way to keep this stats script without maintaining a webpack config merely to generate it... seems not worth it.
nolanlawson
commented
Mar 14, 2019
| ) | ||
| let tree = component.toJSON() | ||
| expect(tree).toMatchSnapshot() | ||
| }) |
There was a problem hiding this comment.
I added a test for the <NotFound> component for the heck of it
nolanlawson
commented
Mar 14, 2019
| this.top = 0 | ||
| this.maxMargin = 0 | ||
| return | ||
| } |
There was a problem hiding this comment.
This makes me wince; maybe eventually we can use NODE_ENV to remove this
nolanlawson
commented
Mar 14, 2019
| @@ -28,7 +28,8 @@ export default class Search extends React.PureComponent { | |||
|
|
|||
| componentDidMount() { | |||
| // in some cases (e.g. preact) the input may already be pre-populated | |||
| if (this.input.value) { | |||
| // this.input is undefined in Jest tests | |||
This was referenced Sep 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves our tests from karma to jest. This offers a few benefits:
I had to make some small tweaks to get this to work, but I managed to preserve our existing tests.