Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding search icon in search input field #205

Merged
merged 2 commits into from
Jul 30, 2018

Conversation

Rena-Ryumae
Copy link

Currently, there is no visual indication
for when the user is searching for an
emoji nor is there an easy way to clear
the input field after the user's search

Our change proposes to add a small magnifying
glass icon to the right hand side of the
search input bar which becomes an x delete
icon when the user types in the search input
bar.

The x delete icon is tabbable and will clear
the search input field with the return (enter)
key, spacebar, and mouse click. The
magnifying glass icon is not tabbable.

Rena Ryumae and others added 2 commits July 13, 2018 13:18
Currently, there is no visual indication
for when the user is searching for an
emoji nor is there an easy way to clear
the input field after the user's search

Our change proposes to add a small magnifying
glass icon to the right hand side of the
search input bar which becomes an x delete
icon when the user types in the search input
bar.

The x delete icon is tabbable and will clear
the search input field with the return (enter)
key, spacebar, and mouse click. The
magnifying glass icon is not tabbable.
@EtienneLem EtienneLem merged commit a7e37ed into missive:master Jul 30, 2018
@cosmocoder
Copy link

@Rena-Ryumae and @EtienneLem there are a couple of small issues with this commit:

  1. The search icon is not vertically centered. Using top: 50%; transform: translateY(-50%) fixes that issue.

  2. The button element does not have the type='button' attribute, this causes a full page reload when it is used inside a form element, while clicking the close button.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants