Unbreaks packages depending on uglify-js running node 0.11.8 #347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I won't include this workaround because the issue should really be fixed in Node (I think it's fixed already). See #329. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the record I am not sure if the tests should be ok like they are or not. I didn't see any errors and I've looked around for reference on how to contribute but couldn't find anything of value.
I'm adding
var fooNamein every function definition (some might not be needed) because well, I was trying to use.parsebut it wasn't available and it took me here. I started here #346I'm good to refactor this in any way that you guys consider it appropriate.
Thanks for making such a good tool!