uglifyjs binary: Make read_whole_file async and don't attempt to read STDIN synchronously #174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… STDIN synchronously.
|
Oh my God, such mess for a single async function! :-) Thanks for the patch, I merged it. For some reason this pull request didn't close automatically. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The weird
do {...fs.readFileSync("/dev/stdin", "utf8");} while (...)construct is causing the uglifyjs binary to behave a bit odd. Eg. on my Ubuntu 12.12 I need to hit ^D twice when ending the input.I've looked around a bit, and it doesn't seem like there's a reliable way to slurp stdin synchronously in node.js, so I tried to make
read_whole_fileasynchronous, which resolves the problems I've had.