Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add .gitattributes to checkout lf eol style #1487

Closed
wants to merge 1 commit into from

Conversation

avdg
Copy link
Contributor

@avdg avdg commented Feb 11, 2017

No description provided.

This was referenced Feb 11, 2017
@alexlamsl
Copy link
Collaborator

I just switched from master and back, and noticed test/compress/drop-console.js also suffers from the CRLF issue.

@avdg
Copy link
Contributor Author

avdg commented Feb 12, 2017

ow :/

@avdg
Copy link
Contributor Author

avdg commented Feb 12, 2017

git grep doesn't help me a lot, it lists a lot of files if I look for \r

@avdg
Copy link
Contributor Author

avdg commented Feb 12, 2017

hmm had to test this on c9

$ git grep -Il $'\r'
test/compress/dead-code.js
test/compress/drop-console.js

@avdg
Copy link
Contributor Author

avdg commented Feb 12, 2017

Pushed fix

@alexlamsl
Copy link
Collaborator

Here's a quick browse using Visual Studio Code for CRLF files:

test/compress/dead-code.js
test/compress/drop-console.js

So I think we are covered 👍

alexlamsl pushed a commit to alexlamsl/UglifyJS that referenced this pull request Feb 18, 2017
@alexlamsl alexlamsl closed this in c06a50f Feb 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants