remove npm-shrinkwrap.json to work around npm@4.0.2 bug #1385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
See test log file to confirm https://travis-ci.org/mishoo/UglifyJS2/jobs/179998657 Click on line 155 |
|
@rvanvelzen We need this fix merged on master and harmony otherwise all future PRs will fail travis-ci tests - including pure documentation fixes such as #1387. |
|
@rvanvelzen Thanks! |
|
Thanks. Although the shrinkwrap is highly beneficial, it's not worth failing builds for. |
|
@rvanvelzen When you have the time could you please merge this PR on to the harmony branch? |
|
@kzc Sure, done! |
|
@rvanvelzen Hmm... I don't see this commit on harmony: https://github.com/mishoo/UglifyJS2/commits/harmony Did you push it? |
|
Oops, I was pushing to a different branch and didn't notice. It should be there now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1384